Skip to content

Build for aarch64-apple-darwin #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 16, 2020

Conversation

shepmaster
Copy link
Member

No description provided.

@shepmaster shepmaster force-pushed the aarch64-apple-darwin branch 4 times, most recently from e861aee to cb19c08 Compare October 15, 2020 11:16
@kinnison
Copy link
Contributor

The macos changes need to go in the actions template, otherwise they'll be lost next time we regenerate the actions files. Also I think the set-env stuff needs changing now :D

@shepmaster
Copy link
Member Author

shepmaster commented Oct 16, 2020

Ah, I was waiting for #2515 and it looks like it’s been addressed.

@shepmaster shepmaster force-pushed the aarch64-apple-darwin branch from cb19c08 to b46366e Compare October 16, 2020 14:30
@shepmaster
Copy link
Member Author

The macos changes need to go in the actions template

Done.

the set-env stuff needs changing now

Done.

@kinnison
Copy link
Contributor

As a final point before I merge this, have you confirmed that rustup believes this is a valid host triple?

@kinnison
Copy link
Contributor

I think it should do, and I seem to recall you running your cross-built binary on an aarch64 mac, but I just want to be sure

@shepmaster
Copy link
Member Author

shepmaster commented Oct 16, 2020

have you confirmed that rustup believes this is a valid host triple?

If I understand you, I think so. rustup actually works “as-is” today:

arch --x86_64 \
sh <(curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs) \
--default-host aarch64-apple-darwin \
--default-toolchain nightly

I expect that this PR removes the need to bring in the x86-64 emulator. A future change to the shell script should reduce it to the usual one-liner.

@kinnison kinnison merged commit df32486 into rust-lang:master Oct 16, 2020
@shepmaster shepmaster deleted the aarch64-apple-darwin branch October 16, 2020 18:15
@est31 est31 mentioned this pull request Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants